[Improvement] Add testcontainer utils for test. #2862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RocMarshal
force-pushed
the
docker_container
branch
from
6538b40
to
8be2e92
Compare
RocMarshal
force-pushed
the
docker_container
branch
2 times, most recently
from
47c77c3
to
7da4e9a
Compare
RocMarshal
changed the title
RocMarshal
force-pushed
the
docker_container
branch
from
7da4e9a
to
3a77d86
Compare
RocMarshal
force-pushed
the
docker_container
branch
4 times, most recently
from
a1f5e9f
to
213271a
Compare
GOODBOY008
reviewed
Aug 7, 2023
| this.jobManagerContainer = | ||
| new FlinkContainer( | ||
| dockerImageName, JOBMANAGER, NETWORK, this.yamlConfStr, slf4jLogConsumer); | ||
| this.jobManagerContainer.addRequiredFixedExposedPorts(BLOB_SERVER_PORT, BLOB_SERVER_PORT); |
There was a problem hiding this comment.
Use fixed port expose will occur port conflicts. Use addExposedPort to add expose port and getMappedPort get mapped expose port.
RocMarshal
force-pushed
the
docker_container
branch
2 times, most recently
from
c57ba81
to
7ebceeb
Compare
RocMarshal
force-pushed
the
docker_container
branch
from
7ebceeb
to
90a518a
Compare
|
@wolfboys Could you help to review it ? Thx~ |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request
Add testcontainer component for flink standalone session cluster.
Brief change log
Add testcontainer component for flink standalone session cluster.
Verifying this change
Added unit test cases.
Does this pull request potentially affect one of the following parts